[PATCH] --one-file-system and automounter

Dick Streefland dick.streefland at altium.nl
Tue Feb 3 13:31:10 GMT 2004


On Monday 2004-02-02 10:32, Wayne Davison wrote:
| Thanks for the patch.  This is already fixed in the CVS version of
| rsync, but it was changed in a slightly different way that I thought I'd
| mention.  When using the --copy-links (-L) or the --copy-unsafe-links
| options, a symlink that points to a file on a different filesystem has
| been traditionally skipped by rsync.  Your patch would change this so
| that rsync copies these files.
| 
| I had been thinking about this distinction (due to my having recently
| patched this), and am wondering, is the old behavior really what we
| want?  I can see arguments both ways:  that a file-name (a symlink that
| we asked to be expanded to a file) on the exclusive filesystem is being
| skipped (which is bad), and that a file that was not contained by the
| exclusive filesystem was skipped (which is good).  What do folks think?

I think that including a symlinked file (or directory) is slightly
less confusing than skipping the symlinks. The man page description of
the --one-file-system option talks about crossing filesystem boundaries
when recursing, and following one symlink is not recursing. Also,
"cp -rxL" behaves like this.

BTW: Your message contained a "Cc: rsync at lists.samba.org", but I only
     received it directly from you, not via de mailing list.

-- 
Dick Streefland                      ////                      Altium BV
dick.streefland at altium.nl           (@ @)          http://www.altium.com
--------------------------------oOO--(_)--OOo---------------------------


More information about the rsync mailing list