[PATCH] --one-file-system and automounter

Wayne Davison wayned at samba.org
Mon Feb 2 18:32:57 GMT 2004

On Mon, Feb 02, 2004 at 12:01:12PM +0100, Dick Streefland wrote:
> The attached patch for rsync-2.6.0 moves the cross-filesystem check to
> just before a directory is traversed. This obsoletes the function
> skip_filesystem() to test the parent directory. The mount point itself
> is still included, but its contents is skipped.

Thanks for the patch.  This is already fixed in the CVS version of
rsync, but it was changed in a slightly different way that I thought I'd
mention.  When using the --copy-links (-L) or the --copy-unsafe-links
options, a symlink that points to a file on a different filesystem has
been traditionally skipped by rsync.  Your patch would change this so
that rsync copies these files.

I had been thinking about this distinction (due to my having recently
patched this), and am wondering, is the old behavior really what we
want?  I can see arguments both ways:  that a file-name (a symlink that
we asked to be expanded to a file) on the exclusive filesystem is being
skipped (which is bad), and that a file that was not contained by the
exclusive filesystem was skipped (which is good).  What do folks think?


More information about the rsync mailing list