No error messages in rsyncd log in 2.6.1pre-1

Wayne Davison wayned at
Tue Apr 27 20:22:42 GMT 2004

On Tue, Apr 27, 2004 at 05:15:25AM -0500, John Van Essen wrote:
> There was a change to rwrite() that seems to be preventing the error
> logging.

Yes, you're right -- 2.6.0 changed this to make more errors go to the
user and fewer to the log file.  Neither the old behavior nor the new is
really the right one going forward, though, so the future code should
really be modified to allow the calling routine to tell us if a message
should be logged to both the user and the log file, or if it is so
sensitive that it should only go to the log file.

If you want to make rsync behave as it did prior to 2.6.0, you could
apply the appended patch.  I have not checked this in, though.

-------------- next part --------------
--- log.c	20 Jan 2004 05:15:14 -0000	1.71
+++ log.c	27 Apr 2004 20:15:06 -0000
@@ -182,7 +182,8 @@ void rwrite(enum logcode code, char *buf
 			send_msg((enum msgcode)code, buf, len);
-		if (io_multiplex_write((enum msgcode)code, buf, len))
+		if (!am_daemon
+		    && io_multiplex_write((enum msgcode)code, buf, len))

More information about the rsync mailing list