[PATCH] open O_TEXT and O_BINARY for cygwin/windows

Dave Dykstra dwd at drdykstra.us
Mon Jan 27 12:23:00 EST 2003

On Mon, Jan 27, 2003 at 10:46:16AM +0100, Lapo Luchini wrote:
> Dave Dykstra wrote:
> >>What, in particular? I'm not a very good testcase, because I use binary
> >>mounts and unix line endings everywhere.
> >>
> >>It compiles and does syncs with remote rsync daemons, which is my normal
> >>usage.
> >>
> >>Max.
> >>   
> >>
> >See if exclude files with DOS line endings work ok for you, and also the
> >other config files if you can.
> >
> >- Dave
> > 
> >
> I can test that before releasing cygwin's 2.5.6-1 package, unfortunately 
> I have almost *no* free time until after friday (university test on 
> thursday ^_^)
> Anyway Max is also right, local issues can be resolved locally with much 
> speed, even if "in the long run" it's of course better to put them in 
> rsync cvs too.

I'm reluctant to rely on cygwin-stream-specific patches because I know
that other people compile it from source too.  Probably the msleep should
be put in for Cygwin only with an ifdef though, or the waiting of the
child removed altogether on Cygwin only.

> BTW: I wonder if the sleepms(30) is still needed, it's quite a bit of 
> time that my "build.samba.org" hourly cron doesn't produce a "hanged 
> rsync"... (must check that too)

I know that some people still experience it, and I don't think anything
has changed in that area since the time that the person who experienced
the hang discovered the hack.

- Dave

More information about the rsync mailing list