Windows and default --modify-window=0

[Lapo Luchini]

jw schultz wrote:

>The 2 second timestamp resolution only applies to some
>windows filesystems.  I think NTFS has timestamp resolution
>in the milliseconds (unlrelated to precision).  It should
>only become an issue when the windows filesystem is the
>destination.
>
This message says it is 2 seconds aso on NTFSD actually:
http://lists.samba.org/pipermail/rsync/2000-July/002491.html

>Further examination shows that it is
>already hacked in options.c for win32:  
>| #ifdef _WIN32
>| int modify_window=2;
>| #else
>| int modify_window=0;
>| #endif
>perhaps something just needs to be added to the #ifdef.
>
Ohhh... I'd add CygWin to the #ifdef too, then.
Grr, I *never* remember what does cygwin define and what not ^_^

Let me check... this message
http://sources.redhat.com/ml/gdb-patches/2001-04/msg00039.html
suggests that to include djgpp, mingw and cygwin the full ifdef should be:

#if defined(__GO32__) || defined(_WIN32) || defined (__CYGWIN__)

Should I add that to the current 2.5.5 cygwin port (creating a -3 release) or 2.5.6 will be short in time?

-- 
Lapo 'Raist' Luchini
lapo at lapo.it (PGP & X.509 keys available)
http://www.lapo.it (ICQ UIN: 529796)