#129135: configure tests for HAVE_STRUCT_STAT_ST_RDEV
Dave Dykstra
dwd at bell-labs.com
Sat Jan 26 07:20:18 EST 2002
On Fri, Jan 25, 2002 at 09:31:44PM +1100, Martin Pool wrote:
> Thankyou dann for the patch, and Colin for reminding me. Well done.
>
> This is in CVS and will be in 2.5.2.
>
> --
> Martin
Here's the patch that was in the bug report:
diff -urN rsync-2.5.1.orig/flist.c rsync-2.5.1/flist.c
--- rsync-2.5.1.orig/flist.c Thu Jan 3 00:09:35 2002
+++ rsync-2.5.1/flist.c Mon Jan 14 22:24:18 2002
@@ -557,7 +557,7 @@
file->gid = st.st_gid;
file->dev = st.st_dev;
file->inode = st.st_ino;
-#ifdef HAVE_ST_RDEV
+#ifdef HAVE_STRUCT_STAT_ST_RDEV
file->rdev = st.st_rdev;
#endif
This solves part of the problem, but there's a related problem discussed in
http://lists.samba.org/pipermail/rsync/2001-November/005358.html
which hasn't yet been addressed. The user reported she was using 2.4.6,
and in that release configure was setting HAVE_ST_RDEV, not
HAVE_STRUCT_STAT_RT_RDEV, so it couldn't have been the above problem. It
looks like this problem was introduced on November 24 in
http://cvs.samba.org/cgi-bin/cvsweb/rsync/configure.diff?r1=1.85&r2=1.86&f=h
which was just 3 days before the message I posted above. According to the
CVS I keep for the rsync binaries I distribute, I didn't upgrade between
November 16 & 30 so I'm quite sure I wasn't testing with the newly broken
version.
- Dave
More information about the rsync
mailing list