[clug] Updated version of VICI

[Brenton Ross]

On Mon, 2018-05-14 at 17:57 +1000, Duncan Roe via linux wrote:

> Hi Brenton,
> 
> On Mon, May 14, 2018 at 03:12:42PM +1000, linux wrote:
> >
> > Duncan,
> >
> > I really appreciate your work on this.
> >
> > However, it would appear (and please correct me if I am wrong) that you
> > have done an install to /usr  and have set $VICI=/usr and then attempted
> > to run make check. This is bound to fail as the test scripts rely in
> > things in the source directory - $VICI/src has to exist for the tests to
> > work.
> 
> Well, no. I re-ran the build with no VICI and make install with VICI=$PWD and it
> went wrong just the same.
> 
> I sent you the logs privately.
> >
> > The Gnu standards for make check only apply to running on the
> > uninstalled (but built) code. They point out that in general it is
> > impossible to know where things have been installed to, so running a
> > check on the installed code is problematic at best. (If a user does make
> > install DESTDIR=some/other/path then paths generated by configure will
> > be invalid.)
> >
> > I would suggest doing a build and check as per the instructions in the
> > README. Then use your packaging stuff to try out the install.
> 
> I didn't use a build dir because I don't care about residual junk - the
> SlackBuild unpacks into /tmp and *removes the old source tree first* (all SBs do
> that).
> >
> > In a few weeks I hope to develop some tests that can be run on the
> > installed software. This will be a separate set of tests that only use
> > installed files.
> > While I hope to generate the configuration file, there is a possibility
> > it will need to be adjusted to match where files have been installed to.
> >
> > Cheers
> > Brenton
> >
> Cheers ... Duncan.
> 

Duncan,
(I replied to the private mail before seeing this.)

As I said, $VICI is used during the configure, so if its not set then
the tests will fail as they will look for data files in /src which
(hopefully) won't exist.

I think your best approach to using SlackBuild would be to follow the
steps in the README to confirm that it all works with your distribution.
Then go through the SlackBuild process to create an installed version.

Cheers
Brenton