[linux-cifs-client] Re: [PATCH 07/13] cifs: convert posix readdir codepath to use cifs_iget

[Jeff Layton]

On Wed, 27 May 2009 09:36:26 -0400
Christoph Hellwig <hch at infradead.org> wrote:

> On Wed, May 27, 2009 at 08:30:28AM -0400, Jeff Layton wrote:
> > Add a new function that converts FILE_INFO_UNIX to fattr, and a readdir
> > lookup function that spawns dentries.
> 
> Looks good to me
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> 
> A bit sad to see the duplicated cifs_unix_basic_to_fattr vs
> cifs_unix_info_to_fattr but we can deal with that later.  Maybe at
> least move cifs_unix_info_to_fattr into inode.c next to
> cifs_unix_basic_to_fattr so that it's more obvious?
> 

Either way -- we can keep cifs_unix_info_to_fattr static if we keep it
in readdir.c for now. I'll plan to eventually consolidate the two
however since it does look like that could be done fairly easily.

I may even just go ahead and do it for the next respin...

-- 
Jeff Layton <jlayton at redhat.com>