[linux-cifs-client] Re: [PATCH 07/13] cifs: convert posix readdir codepath to use cifs_iget

Wed May 27 13:36:26 GMT 2009

On Wed, May 27, 2009 at 08:30:28AM -0400, Jeff Layton wrote:
> Add a new function that converts FILE_INFO_UNIX to fattr, and a readdir
> lookup function that spawns dentries.

Looks good to me

Reviewed-by: Christoph Hellwig <hch at lst.de>

A bit sad to see the duplicated cifs_unix_basic_to_fattr vs
cifs_unix_info_to_fattr but we can deal with that later.  Maybe at
least move cifs_unix_info_to_fattr into inode.c next to
cifs_unix_basic_to_fattr so that it's more obvious?