[linux-cifs-client] Re: cifs-client patch held by moderators?

[Joe Perches]

On Wed, 2008-03-26 at 20:15 -0500, Steven French wrote:
> I saw all of the patch series but did not want to merge at this stage 
> (release candidate 6 of mainline).   In a week or so it should be fine.

OK, that's when I'd expect it accepted/rejected.

> 1) mixed feelings about this, I would like to condense a few routines in 
> cifssmb.c to pass in flags as one variable and wanted to think more about 
> this.

No worries.  Take your time.

Besides, that's kind of what this patch does.
It passes
	cifs_sb->mnt_cifs_flags
instead of
	(cifs_sb->mnt_flags & CIFS_MOUNT_MAP_SPECIAL_CHR)

I had originally used a bool there, but that grows the
object size.  Passing mnt_cifs_flags is simpler and smaller.

Another option is to change several function prototypes to
take a "struct cifs_sb_info *cifs_sb".

That cifs_sb contains *tcon, local_nls and mnt_flags
and would make those function argument lists shorter.

cheers, Joe