[jcifs] Patch for lsa and samr handle leaks

[Michael B Allen]

Hi Shon,

Great work as usual. Not sure why those where empty. JCIFS should do
what Windows does. At any rate I have added your patch to the TODO
list.

Thanks,
Mike

-- 
Michael B Allen
Java Active Directory Integration
http://www.ioplex.com/

On Fri, Sep 19, 2014 at 6:21 PM, Vella, Shon <svella at idauto.net> wrote:
> I had a customer who was getting jcifs.smb.SmbException: 0xC000011F
> (NT_STATUS_TOO_MANY_OPEN_FILES) trying to resolve a whole bunch of SIDs
> against an EMC Celerra NAS device. It looked very similar to what was
> reported in https://lists.samba.org/archive/jcifs/2011-February/009492.html.
>
> I finally tracked it down to LsaPolicyHandle.close() was empty. I'm guessing
> that it isn't a problem when running against windows because it probably
> cleans up the unclosed handles when the RPC handle is closed, whereas it
> appears that the EMC device does not clean them up until the connection is
> broken.
>
> While I was at it I also noticed that SamrDomainHandle, SamrPolicyHandle,
> and SamrAliasHandle also had empty close() methods. Fortunately, in both
> cases most of the protocol pieces were already there, they just needed to be
> hooked up.