[jcifs] Buglet in dcerpc/DcerpcMessage.java

[Michael B Allen]

Hi Del,

Indeed that is a bug and yes, those methods are not actually used by
anything AFAIK. I just fixed it in my local copy.

Thanks,
Mike

-- 
Michael B Allen
Java Active Directory Integration
http://www.ioplex.com/


On Fri, Jun 11, 2010 at 12:12 PM, Del Merritt <del at alum.mit.edu> wrote:
> I've been staring at DcerpcMessage a lot lately.  Part of that staring shows
> that:
>
>    public void unsetFlag(int flag) {
>        flags |= flag;
>    }
>
> Should instead be:
>
>    public void unsetFlag(int flag) {
>        flags &= ~flag;
>    }
>
> I don't see any in-package use of unsetFlag(), but if someone does try to
> use it in their own code, it won't do what I think they would expect in the
> 1.3.14 code base.
>
> -Del
>
>