[jcifs] Buglet in dcerpc/DcerpcMessage.java

Del Merritt del at alum.mit.edu
Fri Jun 11 10:12:00 MDT 2010


I've been staring at DcerpcMessage a lot lately.  Part of that staring 
shows that:

     public void unsetFlag(int flag) {
         flags |= flag;
     }

Should instead be:

     public void unsetFlag(int flag) {
         flags &= ~flag;
     }

I don't see any in-package use of unsetFlag(), but if someone does try 
to use it in their own code, it won't do what I think they would expect 
in the 1.3.14 code base.

-Del



More information about the jCIFS mailing list