[jcifs] Re: ACE Patch in 1.2.7

[Thomas Bley]

The patch looks like this:

diff -Naur jcifs_1.1.11/src/jcifs/smb/SmbComTransaction.java 
jcifs_1.1.11acl2/src/jcifs/smb/SmbComTransaction.java
--- jcifs_1.1.11/src/jcifs/smb/SmbComTransaction.java   2005-05-04 
23:10:46.000000000 -0400
+++ jcifs_1.1.11acl2/src/jcifs/smb/SmbComTransaction.java   2005-05-10 
22:09:32.000000000 -0400
@@ -32,44 +32,47 @@
     private static final int PRIMARY_SETUP_OFFSET        = 61;
     private static final int SECONDARY_PARAMETER_OFFSET  = 51;
 
-    private static final int DISCONNECT_TID      = 0x01;
+    private static final int DISCONNECT_TID   = 0x01;
     private static final int ONE_WAY_TRANSACTION = 0x02;

Maybe jcifs 1.1.11 is my problem ? The patch has several lines marked as 
changed although there is nothing changed ...

Is there any other guy from the samba team who is also a java guru ?

best regards,
Thomas Bley


Michael B Allen wrote:
> On Sat, 28 Jan 2006 22:37:24 +0100
> Thomas Bley <thomas.bley at simple-groupware.de> wrote:
>
>   
>> Hi Mike,
>>
>> I just looked at the ACE-Patch in 1.2.7 and succeeded in merging it.
>> The ACE works pretty good (I tested WinXP and W2k3Sp1 [with 
>> Ad/Exchange], see screenshot).
>> I've also written some small code to do an LDAP-lookup for translating 
>> the SIDs (about 30 lines).
>> Since Samba4 will also have LDAP onboard I think it's a good way to 
>> resolve the SIDs this way when there is no other code available.
>> Can the patch be added to the standard version? (After applying the 
>>     
>
> No. I don't have time to go through a stabilization cycle. We're pretty
> much in maintainence mode only right now.
>
> But don't let that stop you from posting patchs for new fixes. I
> suspect someone will eventually produce a jcifs package with all the
> new stuff like jcifs-ext did.
>
>   
>> patch I got problems with Input/OutputStream, maybe I patched somewhere 
>> wrong ...)
>>     
>
> Someone posted the fix for this a month or two ago. If you find it,
> fix it, and have 'diff' please post a revised patch to the list and I'll
> replace it in the patches directory.
>
> Thanks,
> Mike
>
>