[jcifs] Bug in jcifs.netbios.NameServiceClient

Steve Herndon sherndon at stillsecure.com
Tue Jan 18 15:58:48 GMT 2005


Does the 1.1.7 release fix the problem I reported earlier? I'm assuming 
this release note:

"The DC lookup code has been modified to gracefully  handle  WINS  returning  an  empty  list (e.g. due to temporary network failure)."

refers to my problem?

thanks

steve

Michael B Allen wrote:

>Steve Herndon said:
>  
>
>>Here is the diff:
>>
>>$ diff -c jcifs_1.1.6/src/jcifs/netbios/NameServiceClient.java
>>    
>>
><snip>
>  
>
>>!                 synchronized( response ) {
>>!                     try {
>>!                         response.readWireFormat( rcv_buf, 0 );
>>!                     }
>>!                     catch (NegativeArraySizeException ex) {
>>!                         // Malformed packet. Ignore it
>>!                         continue;
>>!                     }
>>!                     response.received = true;
>>    
>>
>
>So if you get a crappy packet it quits? Ok. I'll look at this. But I think
>it might be a shade wiser for readWireFormat not to throw a
>NegativeArraySizeException in the first place.
>
>Mike
>  
>

-- 
Steve Herndon




More information about the jcifs mailing list