[jcifs] Bug in jcifs.netbios.NameServiceClient

Michael B Allen mba2000 at ioplex.com
Fri Jan 7 03:31:35 GMT 2005


Steve Herndon said:
> Here is the diff:
>
> $ diff -c jcifs_1.1.6/src/jcifs/netbios/NameServiceClient.java
<snip>
> !                 synchronized( response ) {
> !                     try {
> !                         response.readWireFormat( rcv_buf, 0 );
> !                     }
> !                     catch (NegativeArraySizeException ex) {
> !                         // Malformed packet. Ignore it
> !                         continue;
> !                     }
> !                     response.received = true;

So if you get a crappy packet it quits? Ok. I'll look at this. But I think
it might be a shade wiser for readWireFormat not to throw a
NegativeArraySizeException in the first place.

Mike


More information about the jcifs mailing list