[jcifs] SmbException Supercedes boolean?

Allen, Michael B (RSCH) Michael_B_Allen at ml.com
Mon Oct 29 14:34:37 EST 2001


Does anyone have an opinion as to whether or not SmbFile methods should
return boolean now that many throw SmbException? For example, 0.5.1 has:

public boolean mkdir()

which looks like it's java.io.File counterpart and returns true if the directory was
successfully created and false otherwise. For 0.6.0 I was planning on just
adding the throws to this like:

public boolean mkdir() throws SmbException

but returning boolean is rather pointless given that any kind of failure provokes
an SmbException. I don't know of any other context that might make use of
boolean. I think this should just be:

public void mkdir() throws SmbException

Any opinions? Obviously this is pretty important because it's undoubtledly
going to break code so I'd rather only do this once.

Mike





More information about the jcifs mailing list