[distcc] Patch for dcc_unlock()

Fergus Henderson fergus at google.com
Tue Jun 10 18:43:57 GMT 2008


Thanks.

This patch has been integrated in the distcc 3.0 sources at
distcc.googlecode.com (you can thank Craig Silverstein for that).

On Wed, Jun 4, 2008 at 10:17 AM, Sascha Demetrio <saschad at crytek.de> wrote:

> Hi!
>
> The current implementation of dcc_unlock() performs the unlock by
> closing the associated file descriptor. This only works correctly with
> flock() based locking. For fcntl(F_SETLK) and lockf() style locking, the
> lock is associated with the calling process, not with the fd - so an
> explicit unlocking call is required.
>
> The attached patch fixes this problem.
>
> Kind regards,
> Sascha Demetrio
>
> ___
> This message contains confidential information and is intended only for the
> individual named. If you are not the named addressee you should not
> disseminate, distribute or copy this e-mail. Please notify the sender
> immediately by e-mail if you have received this e-mail by mistake and delete
> this e-mail from your system. E-mail transmission cannot be guaranteed to be
> secure or error-free as information could be intercepted, corrupted, lost,
> destroyed, arrive late or incomplete, or contain viruses. The sender
> therefore does not accept liability for any errors or omissions in the
> contents of this message, which arise as a result of e-mail transmission. If
> verification is required please request a hard-copy version. Crytek GmbH -
> http://www.crytek.com
>
> __
> distcc mailing list            http://distcc.samba.org/
> To unsubscribe or change options:
> https://lists.samba.org/mailman/listinfo/distcc
>



-- 
Fergus Henderson <fergus at google.com>
-------------- next part --------------
HTML attachment scrubbed and removed


More information about the distcc mailing list