[distcc] Patch for dcc_unlock()

Sascha Demetrio saschad at crytek.de
Wed Jun 4 14:17:24 GMT 2008


The current implementation of dcc_unlock() performs the unlock by
closing the associated file descriptor. This only works correctly with
flock() based locking. For fcntl(F_SETLK) and lockf() style locking, the
lock is associated with the calling process, not with the fd - so an
explicit unlocking call is required.

The attached patch fixes this problem.

Kind regards,
Sascha Demetrio

This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message, which arise as a result of e-mail transmission. If verification is required please request a hard-copy version. Crytek GmbH - http://www.crytek.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: distcc-2.18.3-lockpatch.diff
Type: application/octet-stream
Size: 1190 bytes
Desc: not available
Url : http://lists.samba.org/archive/distcc/attachments/20080604/1c1e3120/distcc-2.18.3-lockpatch.obj

More information about the distcc mailing list