[distcc] 0.5rc2

[Martin Pool]

On 28 Jun 2002, Claes Wallin <clawa570 at cyd.liu.se> wrote:
> On my FreeBSD box, 0.5rc2 works fine from inetd (gmake check works
> nicely if i remove the lines starting/stopping the daemon), however
> it always fails when running as a standalone server (some extra
> debug code added):

Thanks for the nice bug report.

Could you try this patch please?

--- dparent.c.~1.8.~	Thu Jun 27 21:33:06 2002
+++ dparent.c	Fri Jun 28 16:35:39 2002
@@ -127,7 +127,7 @@ static void dcc_catch_signals(void)
 
     memset(&act_exited, 0, sizeof act_exited);
     act_exited.sa_handler = dcc_child_exited;
-    act_exited.sa_flags = SA_NOCLDSTOP;
+    act_exited.sa_flags = SA_NOCLDSTOP|SA_RESTART;
 
     if (sigaction(SIGTERM, &act_catch, NULL)
         || sigaction(SIGHUP, &act_catch, NULL)
@@ -150,6 +150,8 @@ static void dcc_reap_kids(void)
         } else if (kid == -1) {
             if (errno == ECHILD) {
                 break;
+            } else if (errno == EAGAIN || errno == EINTR) {
+                continue;       /* loop again */
             } else {
                 rs_log_error("wait failed: %s", strerror(errno));
                 dcc_exit(EXIT_DISTCC_FAILED);

> distccd[23176] ERROR: (dcc_critique_status) compile on arlington.h20.ryd.student.liu.se died with signal 28 (core dumped)
> distccd[23176] input file: 5600 bytes; output file: 0 bytes
> 
> > died with signal 28
> 
> Sometimes it's 104, quite a few times it's been 59. Any ideas? What
> does this signal mean, anyway?

It means nothing; it's an uninitialized variable.

-- 
Martin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/distcc/attachments/20020627/9ab2684d/attachment.bin