[cifs-protocol] RE: erroneous references to little-endian

[Richard Guthrie]

Andrew,

We have completed our investigation and have updated the documentation to remove references that specify a parameter as little endian where the values endianess is negotiated by the underlying RPC protocol as we discussed previously.  Here is the list of fields in which the endianess text was removed:

2.2.1.3.1   NL_AUTH_MESSAGE - MessageType
2.2.1.3.1   NL_AUTH_MESSAGE - Flags
2.2.1.3.6   NETLOGON_WORKSTATION_INFO - WorkstationFlags
2.2.1.3.11   NETLOGON_DOMAIN_INFO - WorkstationFlags
2.2.1.4.15   NETLOGON_LOGON_IDENTITY_INFO -Control
2.2.1.5.3   NETLOGON_DELTA_ACCOUNTS - PrivilegeControl
2.2.1.5.3   NETLOGON_DELTA_ACCOUNTS - PrivilegeAttributes
2.2.1.5.3   NETLOGON_DELTA_ACCOUNTS - SystemAccessFlags
2.2.1.5.13   NETLOGON_DELTA_GROUP - Attributes
2.2.1.5.15   NLPR_USER_PRIVATE_INFO - DataType
2.2.1.5.15   NLPR_USER_PRIVATE_INFO - LmLength
2.2.1.5.15   NLPR_USER_PRIVATE_INFO - NtLength
2.2.1.5.15   NLPR_USER_PRIVATE_INFO - LmHistoryLength
2.2.1.5.15   NLPR_USER_PRIVATE_INFO - NtHistoryLength
2.2.1.6.2   DS_DOMAIN_TRUSTSW - Flags
2.2.1.6.2   DS_DOMAIN_TRUSTSW - TrustType
2.2.1.6.2   DS_DOMAIN_TRUSTSW - TrustAttributes
2.2.1.7.2   NETLOGON_INFO_1 - netlog1_flags
2.2.1.7.3   NETLOGON_INFO_2 - netlog2_flags
3.5.4.2.1   DsrGetDcNameEx2 (Opnum 34) - AllowableAccountControlBits
3.5.4.2.1   DsrGetDcNameEx2 (Opnum 34) - Flags
3.5.4.4.1   NetrLogonSamLogonEx (Opnum 39) - ExtraFlags
3.5.4.4.2   NetrLogonSamLogonWithFlags (Opnum 45) - ExtraFlags
3.5.4.5.4   NetrDatabaseRedo (Opnum 17) - Flags
3.5.4.6.1   DsrEnumerateDomainTrusts (Opnum 40) - Flags
3.5.4.6.5   DsrGetForestTrustInformation (Opnum 43) - Flags
3.5.4.7.5   NetrLogonSetServiceBits (Opnum 22) - ServiceBitsOfInterest
3.5.4.7.5   NetrLogonSetServiceBits (Opnum 22) - ServiceBits

A future documentation release should contain these changes.  Please let us know if you have any further questions/comments.

Richard Guthrie
Support Escalation Engineer 
Open Protocols Support Team
http://blogs.msdn.com/OpenSpecification 
Tel: +1 (469) 775-7794
E-mail: rguthrie at microsoft.com 



-----Original Message-----
From: Andrew Bartlett [mailto:abartlet at samba.org] 
Sent: Wednesday, April 15, 2009 7:13 AM
To: Interoperability Documentation Help
Cc: pfif at tridgell.net; cifs-protocol at samba.org
Subject: erroneous references to little-endian

Before many (but oddly, not all) of the impossible-to-parse bitfield diagrams in MS-NRPC is the statement:

> A set of bit flags in little-endian format ... A flag is TRUE (or set) 
> if its value is equal to 1. The value is constructed from zero or more bit flags from the following table.

(search for little-endian)

These refer to bitfields are transferred over DCE/RPC, and as such are in negotiated bit order, as chosen by the client and server.  Therefore the reference to their bit order should be removed.  (This is doubly confusing because the table itself is in bit-endian order. :-)

There are exceptions where the use is actually correct - the IP address and credentials calculations, or in conjunction with non-RPC structures, but the rest appear to be a copy-and-pasted template reproduced though the entire document.

Can you please review this (and other RPC protocols) to ensure that these references are corrected?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com