[ccache] [PATCH] Always close(fd) as soon as file is mmap()'d.
joel at rosdahl.net
Sun Feb 28 08:44:13 MST 2010
On Sun, 28 Feb 2010 12:22:56 -0300
Ramiro Polla <ramiro.polla at gmail.com> wrote:
> On Sun, Feb 28, 2010 at 5:52 AM, Joel Rosdahl <joel at rosdahl.net> wrote:
> > On Sat, 27 Feb 2010 22:15:54 -0300
> > Ramiro Polla <ramiro.polla at gmail.com> wrote:
> >> On remember_include_file(), close() wasn't even being called. On
> >> unify_hash() and process_preprocessed_file(), it might not be closed
> >> if mmap fails.
> > Thanks for finding this! But I think you forgot to attach your patch?
> Hmm, gmail says it's attached. Let's try again.
Thanks, got it.
Apparently, the mailing list settings were quite paranoid regarding
attachments and stripped your patch. I've now loosened the attachment
type filter somewhat.
More information about the ccache