[Samba] chmod of smbpasswd file

Jones Syue 薛懷宗 jonessyue at qnap.com
Fri Jan 12 07:17:36 UTC 2024


> It's an easy fix to remove it. Just raise a bug, submit a merge and I'll get it
> reviewed and pushed.
> 
> Probably best thing to do is change this to do an fstat and
> log a warning message if 'rw' is set for anything other than
> owner.

https://bugzilla.samba.org/show_bug.cgi?id=15555
Filed a bug and a patch is proposed: add fstat() to bypass [f]chmod() if 
the password file has valid permissions 0600. 

We had a similar case before,
a bit different is the password file is resident on a writable ext3/ext4, 
and contantly [f]chmod() might have a performance impact on entry-level 
systems since dirty pages syncing is expensive, hope this helps :)

--

Regards,
Jones Syue | 薛懷宗
QNAP Systems, Inc.


More information about the samba mailing list