smbclient - put broken

[Jeremy Allison]

On Thu, May 08, 2008 at 08:10:54PM -0700, Jeremy Allison wrote:
> On Thu, May 08, 2008 at 10:43:56PM -0400, simo wrote:
> > Team,
> > Kai discovered that smbclient in Fedora 9 packages (3.2.0-pre3) is
> > broekn, and I was able to reproduce the same thing with v3-2-stable.
> > 
> > Apparently trying to put any file on an smb server will result in the
> > file being created but zero bytes transferred. The file is 0 bytes long
> > on the receiving end when the operation finishes.
> > 
> > I will try to look into this tomorrow, but if you feel to look into it
> > before I wake up on this side of the sea please do it :-)
> 
> I thought this was a bug that Volker found and fixed before the
> last pre-release with his async write code. I'll look at this
> tomorrow. May be something not pulled into stable.

Nope, not Volker's fault - mine. A bugfix for the xfile code
that caused x_fopen not to be buffered correctly due to x_setvbuf
failing due to an x_flush check failing.

I'll fix this asap. Tomorrow I'll look at adding a build farm
check for testing put/get.

Jeremy.