DO NOT REPLY [Bug 5403] -H (--hard-links) is broken when sending to remote

samba-bugs at samba.org samba-bugs at samba.org
Wed Jul 30 01:21:24 GMT 2008


https://bugzilla.samba.org/show_bug.cgi?id=5403


wayned at samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Version|3.0.2                       |3.0.4




------- Comment #11 from wayned at samba.org  2008-07-29 20:21 CST -------
I have also added a cast to int64 (which is the internal type used for all
device and inode numbers) so that a 32-bit device number with all bits on will
still be non-zero in the hard-link processing (as long as a dev_t is unsigned,
which it should be).  Of course, a 64-bit device number with all bits on will
overflow to zero, but the current hash code must reserve one number (out of the
18,446,744,073,709,551,615 values available) to indicate that a hash position
is empty, and so choosing an st_dev of 0xffff_ffff_ffff_ffff as the odd-man-out
seems like the best choice.

This fix will go out in the next 3.0.4 pre-release (which will probably be the
final pre-release for 3.0.4).


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


More information about the rsync mailing list