possible bug rsync-2.5.5 rsyncd.conf option "max connections"

[Dick Snippe]

Hello,

I think i may have found a bug in the "max clients" option in rsyncd.conf
[we use rsync-2.5.5; All platforms I tried (Irix-6.5.14 and various linux
flavours) show the behaviour explained below]

The manpage says:

|max connections
|      The  "max connections" option allows you to specify
|      the maximum number of simultaneous connections  you
|      will allow to this module of your rsync server. Any
------------------^^^^^^^^^^^^^^

However, it appears that the check also counts connections to other modules.

Simple example:

/etc/syncd.conf
|[foo]
|        path = /
|        max connections = 1
|[bar]
|        path = /
|        max connections = 2

Now try these two modules in parallel, where the first line is
started before the second line:
|shell1 $ rsync -an server::foo /tmp/foo
|<starts spewing output>
|shell2 $ rsync -an server::bar /tmp/bar
|<starts spewing output>

This works, as expected.
Now for a new experiment:

|shell2 $ rsync -an server::bar /tmp/bar
|<starts spewing output>
|shell1 $ rsync -an server::foo /tmp/foo
|@ERROR: max connections (1) reached - try again later

Imho module foo complains about the connection to module bar;
Could this be a bug?

After some browsing in the code I guess that the problem might be that
only one lockfile /var/run/rsyncd.lock) is used for all modules.

-- 
Dick Snippe Unix Beheerder/Specialist
NOS Internet beheer: beheer at omroep.nl	\ fight war
Gateway C -- Kamer 110 -- 035 6774093	 \ not wars
Infosite http://intra.omroep.nl/info/				[]()