[PATCH][SMB3 client] add dynamic trace points for smbdirect (RDMA) connect

Tom Talpey tom at talpey.com
Tue Sep 19 14:34:25 UTC 2023


On 9/18/2023 11:20 PM, Steve French wrote:
>       smb3_smbd_connect_done and smb3_smbd_connect_err
> 
> To improve debugging of RDMA issues add those two new tracepoints. We
> already had dynamic tracepoints for the non-RDMA connect done and
> error cases, but didn't for the smbdirect cases.
> 
> See attached patch
> 


This looks fine but it's pretty basic. The entire smbdirect handling
in both client and server has its own idea of debug, with two (very)
different ways to enable various levels. It requires a silly combination
of /proc, ksmbd.control, "class" and "level" selections, and some weird
other thing I don't even try to remember. Combined with the ancient
cifs_dbg stuff, it is all just... unprintable.

Anyway
Acked-by: Tom Talpey <tom at talpey.com>

Tom.



More information about the samba-technical mailing list