[PATCH][smb3 client] allow debugging session and tcon info to improve stats analysis and debugging

Steve French smfrench at gmail.com
Fri Nov 10 07:09:50 UTC 2023


Fixed one minor bug (missing cifs_put_tlink call to free reference on
tlink) and updated cifs-2.6.git for-next

See attached (updated patch)


On Thu, Nov 9, 2023 at 8:51 PM Steve French <smfrench at gmail.com> wrote:
>
> Updated patch to remove dumping of flags (tcon->Flags was already
> supposed to be dumped via
> the other ioctl (CIFS_IOC_GET_MNT_INFO) but it had a minor bug - will
> send followon patch for that)
>
>
> On Thu, Nov 9, 2023 at 3:51 PM Steve French <smfrench at gmail.com> wrote:
> >
> > [PATCH] smb3: allow debugging session and tcon info to improve stats
> >  analysis and debugging
> >
> > When multiple mounts are to the same share from the same client it was not
> > possible to determine which section of /proc/fs/cifs/Stats (and DebugData)
> > correspond to that mount.  In some recent examples this turned out to  be
> > a significant problem when trying to analyze performance problems - since
> > there are many cases where unless we know the tree id and session id we
> > can't figure out which stats (e.g. number of SMB3.1.1 requests by type,
> > the total time they take, which is slowest, how many fail etc.) apply to
> > which mount.
> >
> > Add an ioctl to return tid, session id, tree connect count and tcon flags.
> >
> > --
> > Thanks,
> >
> > Steve
>
>
>
> --
> Thanks,
>
> Steve



--
Thanks,

Steve
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-smb3-allow-dumping-session-and-tcon-id-to-improve-st.patch
Type: application/x-patch
Size: 3435 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20231110/37955b11/0001-smb3-allow-dumping-session-and-tcon-id-to-improve-st.bin>


More information about the samba-technical mailing list