patches to move ksmbd and cifs under new subdirectory

Steve French smfrench at gmail.com
Wed May 24 02:41:02 UTC 2023


Lightly updated (e.g. to include a missing trivial change needed to
Documentation/filesystems/index.rst that Namjae noticed).  See
attached.

Presumably can defer the additional cleanup/prettying (ie those beyond
those required for the directory rename) with distinct patches later.

On Tue, May 23, 2023 at 12:35 PM Linus Torvalds
<torvalds at linux-foundation.org> wrote:
>
> On Mon, May 22, 2023 at 11:39 PM Steve French <smfrench at gmail.com> wrote:
> >
> > My reason for adding CONFIG_SMB_CLIENT, enabling CONFIG_SMB_CLIENT
> > when CONFIG_CIFS was enabled, I was trying to make the Makefile more clear
> > (without changing any behavior):
>
> That sounds ok, but I think it should be done separately from the
> move. Keep the move as a pure move/rename, not "new things".
>
> Also, when you actually do this cleanup, I think you really should just do
>
>   config SMB
>         tristate
>
>   config SMB_CLIENT
>         tristate
>
> to declare them, but *not* have that
>
>         default y if CIFS=y || SMB_SERVER=y
>         default m if CIFS=m || SMB_SERVER=m
>
> kind of noise anywhere. Not for SMBFS, not for SMB_CLIENT.
>
> Just do
>
>         select SMBFS
>         select SMB_CLIENT
>
> in the current CIFS Kconfig entry. And then SMB_SERVER can likewise do
>
>         select SMBFS
>
> and I think it will all automatically do what those much more complex
> "default" expressions currently do.
>
> But again - I think this kind of "clean things up" should be entirely
> separate from the pure code movement. Don't do new functionality when
> moving things, just do the minimal required infrastructure changes to
> make things work with the movement.
>
>               Linus



-- 
Thanks,

Steve
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-smb-move-client-and-server-files-to-common-directory.patch
Type: text/x-patch
Size: 43079 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20230523/4c71b07f/0001-smb-move-client-and-server-files-to-common-directory.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-cifs-correct-references-in-Documentation-to-old-fs-c.patch
Type: text/x-patch
Size: 5631 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20230523/4c71b07f/0002-cifs-correct-references-in-Documentation-to-old-fs-c.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-smb3-move-Documentation-filesystems-cifs-to-Document.patch
Type: text/x-patch
Size: 2784 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20230523/4c71b07f/0003-smb3-move-Documentation-filesystems-cifs-to-Document.bin>


More information about the samba-technical mailing list