atomic ops in heimdal: -latomic

[Andrew Bartlett]

On Mon, 2023-06-12 at 13:06 +0300, Michael Tokarev via samba-technical
wrote:
> Hi!
> 
> Something changed - probably in Debian (where I build packages), and
> some stuff
> started failing, eg
> 
> https://buildd.debian.org/status/fetch.php?pkg=samba&arch=armel&ver=2%3A4.18.3%2Bdfsg-1&stamp=1686556171&raw=0
> 
> 
> /usr/bin/ld: third_party/heimdal/lib/krb5/krcache.c.55.o: in function
> `krcc_get_principal':
> ./bin/default/../../third_party/heimdal/lib/krb5/krcache.c:1395:
> undefined reference to `__atomic_load_8'
> Apparently this now needs -latomic on the link line. I don't know yet
> why it ended up like this,
> but other projects which faced this same issue, just added -latomic
> in similar cases.

Any chance of building a configure test for waf to detect this? 

How do we know if we need this?

Once you have the test, it should just be a matter of adding a
dependency on 'atomic' in the right spot, on platforms that don't find
the library this will just be empty (eg ignored in the dep calcuation),
you don't need to do string manipulation in the subsystem declarations.

Andrew Bartlett


-- 
Andrew Bartlett (he/him)       https://samba.org/~abartlet/
Samba Team Member (since 2001) https://samba.org
Samba Team Lead                https://catalyst.net.nz/services/samba
Catalyst.Net Ltd

Proudly developing Samba for Catalyst.Net Ltd - a Catalyst IT group
company

Samba Development and Support: https://catalyst.net.nz/services/samba

Catalyst IT - Expert Open Source Solutions