increased `make test` logging in syslog with "debug syslog format = always"

[Martin Schwenke]

On Wed, 26 Jul 2023 11:13:01 +1200, Douglas Bagnall via samba-technical
<samba-technical at lists.samba.org> wrote:

> On 25/07/23 17:42, Andrew Bartlett wrote:
> 
> > My intention was only to change the output format, not the destination,
> > so as to get more information (time and host etc) in the logs as the
> > previous logging to 'stdout' lost a lot of information.  
> 
> Yeah.
> 
> I can get complete `make test` syslog silence with the following patch, but I 
> don't know yet if it ruins some clever test of our logging itself.
> 
> cheers,
> Douglas
> 
> 
> 
> commit 51e857217846e9555affb94b7b588d363e126128 (HEAD -> 
> conditional-aces-the-true-story)
> Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
> Date:   Wed Jul 26 11:04:53 2023 +1200
> 
>      selftest: avoid logging to syslog in `make test`
> 
>      Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
> 
> diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
> index 0bd77e906d5..3eb2388e298 100755
> --- a/selftest/target/Samba4.pm
> +++ b/selftest/target/Samba4.pm
> @@ -1220,6 +1220,7 @@ sub provision($$$$$$$$$$$)
>          # fruit:copyfile is a global option
>          fruit:copyfile = yes
> 
> +       logging = file
>          $extra_smbconf_options
> 
>   [tmp]
> 
> 

Yes, that is in Samba3.pm, so will work around the problem.

The confusing thing is that MR 3034, as per Andrew's intention, should
only change the logging format and not the logging destination.  If it
does change the destination then that's a regression, so we should hunt
it down and fix it.

Are you able to post examples of lines that end up in syslog?

Thanks...

peace & happiness,
martin