I used --enable-developer and all I got was this lousy build failure ...

[Joseph Sutton]

On 1/09/23 1:15 am, Richard Sharpe via samba-technical wrote:
> Hi folks,
> 
> I user --enable-developer on configure and then built and got this:
> 
> --------------------
> ../../third_party/heimdal/lib/hcrypto/rsa-ltm.c: In function
> ‘ltm_rsa_public_decrypt’:
> ../../third_party/heimdal/lib/hcrypto/rsa-ltm.c:261:9: error: ‘size’
> may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
>       size--; p++;
>       ~~~~^~
> ../../third_party/heimdal/lib/hcrypto/rsa-ltm.c:262:20: error: ‘p’ may
> be used uninitialized in this function [-Werror=maybe-uninitialized]
>       while (size && *p == 0xff) {
>                      ^~
> cc1: all warnings being treated as errors
> 
> ../../third_party/heimdal/lib/hcrypto/bn.c: In function ‘hc_BN_is_bit_set’:
> ../../third_party/heimdal/lib/hcrypto/bn.c:238:24: warning: cast
> discards ‘const’ qualifier from pointer target type [-Wcast-qual]
>       heim_integer *hi = (heim_integer *)bn;
>                          ^
> ../../third_party/heimdal/lib/hcrypto/bn.c: In function ‘hc_BN_get_word’:
> ../../third_party/heimdal/lib/hcrypto/bn.c:309:24: warning: cast
> discards ‘const’ qualifier from pointer target type [-Wcast-qual]
>       heim_integer *hi = (heim_integer *)bn;
> -----------------
> 
> How do I fix this?
> 

I submitted fixes for these build errors to the Heimdal project, but it 
seems it will be a while before they get merged.

https://github.com/heimdal/heimdal/pull/1183/commits/b1d19728db62c560951f4c023244147049151bf4

Regards,
Joseph