tevent test failures on debian

[Michael Tokarev]

Hi!

I'm seeing somewhat strange, to my taste, tevent test failures on
debian salsa-ci, without an apparent reason, which is quite puzzling.

The change which triggers the failures seems to be quite innocent.
It is the debian tevent binary package build procedure, which is done
in a form of makefile (named debian/rules), with a help of a set of
"debhelper" tools.  Here's the commit which immediately triggers the
failure:

--- a/debian/rules
+++ b/debian/rules
@@ -35,2 +35,5 @@ override_dh_auto_build: bin/config-stamp

+override_dh_auto_test:
+       ${MAKE} -j2 test
+
  override_dh_auto_install:

what is going on there. debhelper which is used to build this package,
runs override_dh_auto_build target, which builds the package
(${MAKE} all). Next, if there's no override_dh_auto_test target
in d/rules, it runs dh_auto_test, which by default runs this:

   make -j2 test VERBOSE=1

which turns into

  PYTHONHASHSEED=1 WAF_MAKE=1  `PATH=buildtools/bin:../../buildtools/bin:$PATH which waf` test

and this one succeeds.

Now I'd love to experiment with the test target, to make it verbose.
So I override dh_auto_test target and run ${MAKE} directly just like
dh_auto_test does, as per the above diff.  This target is now being
run instead of the default dh_auto_test, and it gives:

   debian/rules override_dh_auto_test
make[1]: Entering directory '/builds/samba-team/tevent/debian/output/source_dir'
/usr/bin/make -j1 test
make[2]: Entering directory '/builds/samba-team/tevent/debian/output/source_dir'
PYTHONHASHSEED=1 WAF_MAKE=1  `PATH=buildtools/bin:../../buildtools/bin:$PATH which waf` test
test: test_fd_tag
success: test_fd_tag
test: test_timer_tag
success: test_timer_tag
test: test_signal_tag
success: test_signal_tag
test: test_immediate_tag
success: test_immediate_tag
test: test_trace_event_fd__loop
failure: test_trace_event_fd__loop [
tctx->before_handler
../../tests/test_tevent_trace.c:398: error: Failure!
]
...

it *seems* to be doing exactly the same thing (minus the VERBOSE=1),
I even added the same -j2 just out of curiocity (it fails without -j too).
But the test fails.

What is this particular test about, anyway?  There's one more test
failing in the same way:

test: test_trace_event_fd__free_in_handler
failure: test_trace_event_fd__free_in_handler [
tctx->before_handler
../../tests/test_tevent_trace.c:491: error: Failure!
]

(which is also about before_handler).

What this particular failure means?

The logs:

https://salsa.debian.org/samba-team/tevent/-/jobs/2666368 -- build ok
https://salsa.debian.org/samba-team/tevent/-/jobs/2666380 -- test fails

Help?

Thank you!

/mjt