[PATCH] Fix sigsegv in check_stream in smbtorture smb2.streams.io

[Gordon Ross]

That's fine too.  Thanks.

On Tue, Apr 20, 2021 at 3:55 PM Jeremy Allison <jra at samba.org> wrote:
>
> On Tue, Apr 20, 2021 at 03:36:28PM -0400, Gordon Ross via samba-technical wrote:
> >Not 100% sure this is still a defect on master, but it was fairly recently.
> >
> >If any stream create fails during smb2.streams.io
> >the test dies with a sigsegv in torture_comment
> >
> >torture_comment calls need a struct torture_context arg,
> >not its mem_ctx child.  Use talloc_parent().  Also
> >need to call torture_result somewhere on failure.
>
> Thanks Gordon ! Probably better to pass down
> an extra struct torture_context *tctx parameter
> to check_stream() rather than relying on talloc_parent()
> to assume it's a tctx.
>
> If I make those changes are you OK with your
> "Signed-off-by: Gordon Ross <gordon.ross at tintri.com>"
> being added ?
>
> Cheers,
>
> Jeremy.