CI failure on account of C99

Philipp Gesang philipp.gesang at intra2net.com
Tue Apr 13 12:49:13 UTC 2021


On Tuesday, 2021-04-13 22:20:31 +1200 Douglas Bagnall <douglas.bagnall at catalyst.net.nz> wrote 
> On 13/04/21 9:34 pm, Philipp Gesang via samba-technical wrote:
> >     ../../lib/util/tests/time.c:119:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
> >       for (int i = 0; i < sizeof(data) / sizeof(data[0]); ++i) {
> >       ^
> >     ../../lib/util/tests/time.c:119:2: note: use option -std=c99 or -std=gnu99 to compile your code
> > 
> > AFAICS there’s numerous C99 constructs all over the source and
> > README.Coding explicitly mentions it. Is there a special
> > precaution that must be taken for this test target to work?
> 
> The Samba style is to declare all the things first.

Ok, centos7 is happy now. Thanks for the explanation.

Philipp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20210413/0f413daa/signature.sig>


More information about the samba-technical mailing list