[PATCH] lib:util: Fix tfork return value if sigprocmask fails
Jeremy Allison
jra at samba.org
Wed May 15 23:55:13 UTC 2019
On Sat, May 11, 2019 at 09:31:44PM +0200, Rikard Falkeborn via samba-technical wrote:
> Returning a non-zero value from a function with bool as return value is
> the same as returning true. Change the return value to false if
> sigprocmask or pthread_sigmask fails to indicate failure.
>
> Detected with the help of cppcheck.
>
> There are a couple of similar issues in the source3 directory, I wasn't sure
> if this directory is in use and if it's worth fixing these as well?
Yes it's in use and thanks ! Please send in any fixes you might find.
More information about the samba-technical
mailing list