[PATCHES] lib/winbind_util: Add winbind_xid_to_sid for --without-winbind (was Re: winbind_xid_to_sid)

Jeremy Allison jra at samba.org
Tue Mar 5 19:51:01 UTC 2019


On Tue, Mar 05, 2019 at 12:08:27PM -0700, Christof Schmitt via samba-technical wrote:
> On Tue, Mar 05, 2019 at 11:48:18AM -0700, Christof Schmitt via samba-technical wrote:
> > On Tue, Mar 05, 2019 at 10:54:12AM -0600, Christopher O Cowan via samba-technical wrote:
> > > 
> > > This is minor nit, but if I do a waf configure on AIX with the
> > > --without-winbind, I still get a reference to winbind_xid_to_sid from
> > > libsamba-passdb.so.
> > > 
> > > I haven't crawled through the waf code to figure out why, and it's not a
> > > big deal to just compile with winbind, but it should probably be fixed.
> > 
> > The Linux build has the same issue. That is tied to the recent change in
> > passdb. I will post a patch shortly to fix this.
> 
> Here are the patches. The first two fix existing issues on Linux with
> --picky-developer and the third one is the fix for your issue.

LGTM. RB+ and pushed. Thanks Christof !



More information about the samba-technical mailing list