[PATCH] Add "locks_latency" to "ctdb -Y statistics"

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Jan 15 07:42:24 UTC 2019


On Tue, Jan 15, 2019 at 10:04:53AM +1100, Martin Schwenke wrote:
> On Mon, 14 Jan 2019 15:16:39 +0100, Volker Lendecke via samba-technical
> <samba-technical at lists.samba.org> wrote:
> 
> > Review appreciated!
> 
> Oh, wow!  That is (now) obviously missing...
> 
> The if-statement above the hunk in your patch prints headers, which
> includes already *_lockwait_latency.  It is between *_call_latency and
> *_childwrite_latency.
> 
> This means you need to print the s->locks.latency.* values between where
> the s->call_latency.* and s->childwrite_latency.* are printed.  You've
> printed them first.  :-)

To be honest, I was completely confused about the precise meaning. So
put it wherever it's required :-)

Thanks!

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-370000-0, mailto:kontakt at sernet.de
Gesch.F.: Dr. Johannes Loxen und Reinhild Jung
AG Göttingen: HR-B 2816 - http://www.sernet.de



More information about the samba-technical mailing list