[PATCH] flock() files even with a permissive share mode.

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Feb 4 19:25:54 UTC 2019


On Mon, Feb 04, 2019 at 11:31:20AM -0700, Christof Schmitt wrote:
> > The NFS people I met do not see this as a priority, nobody ever could
> > allocate time. Locking seems to be a topic nobody outside the SMB
> > world ever looks at. We need to keep the VFS call in, because I know
> > of at least one vendor who has this implemented in his proprietary
> > file system. For the rest -- I don't think it matters if we keep it
> > in.
> 
> Do you mean what we have implemented for gpfs? Or is there another file
> system that can enforce share modes?

Yes, I meant GPFS.

> I see the problems with the flock call. The main advantage of keeping it
> would be having an easy way to test the vfs call. We could add a test
> for this to autobuild to ensure that the codepath is excersized, but if
> gpfs is the only actual user, that probably would fall on me.

This might mean we need a mock implementation of that call somewhere
in autobuild, assuming we don't have it available on sn-devel the way
GPFS does it.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-370000-0, mailto:kontakt at sernet.de
Gesch.F.: Dr. Johannes Loxen und Reinhild Jung
AG Göttingen: HR-B 2816 - http://www.sernet.de



More information about the samba-technical mailing list