[PATCH] re-add pidl install
Andrew Bartlett
abartlet at samba.org
Wed Aug 28 19:13:18 UTC 2019
On Thu, 2019-08-29 at 06:32 +1200, Andrew Bartlett via samba-technical
wrote:
> On Wed, 2019-08-28 at 19:08 +0200, Günther Deschner via samba-technical
> wrote:
> > Hi,
> >
> > attached a patch to re-add the pidl waf install. At least openchange,
> > although a dormant project atm, requires pidl to be available in the system.
> >
> > https://gitlab.com/samba-team/devel/samba/pipelines/78660819
> >
> > Please review & push.
>
> If needed, why can't it use the perl MakeMaker makefile based build
> that we have tested in autobuild?
>
> Also, please use GitLab merge requests for patches to Samba, for
> consistency.
I would note for context that this was removed because it was not an
optional install, but a mandatory part of 'make install', which was a
problem for this vendor (Google).
>From memory I suggested removing it (given the independent makefile)
rather than adding a '--without-perl' or similar option to our already
over-complex configure script.
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list