[PATCH] use current working directory instead of share path in cephwrap_realpath
Ralph Böhme
slow at samba.org
Mon Apr 29 20:37:11 UTC 2019
> Am 26.04.2019 um 22:41 schrieb Jeremy Allison via samba-technical <samba-technical at lists.samba.org>:
>
> On Fri, Apr 26, 2019 at 10:36:24PM +0200, Robert Sander via samba-technical wrote:
>> Hi,
>>
>> reading symbolic links from a CephFS via vfs_ceph does not always work.
>> It looks like the CWD instead of the share path should be used to
>> construct the real path.
>
> Yes, that's completely correct. Thanks a *LOT* for catching
> that. I'll log a bug to track.
>
> We now change to $cwd to prevent symlink races
> so handle->conn->connectpath isn't always the
> directory we're in anymore.
>
>> Attached is a patch that changes this. Please review.
>
> RB+. Can I get a second Team reviewer please ?
+1
Robert, your patch is missing a Signed-off tag. Can you please check out
https://wiki.samba.org/index.php/CodeReview#commit_message_tags
and let us know if you're happy with one of us adding the tag on your behalf? You may as well update the patch and resubmit to the list. :)
Thanks!
-slow
--
Ralph Boehme, Samba Team https://samba.org/
Samba Developer, SerNet GmbH https://sernet.de/en/samba/
GPG-Fingerprint FAE2C6088A24252051C559E4AA1E9B7126399E46
More information about the samba-technical
mailing list