[PATCH] s3: Fix the build when compiling without JSON support

[Douglas Bagnall]

On 26/09/18 02:14, Philipp Gesang via samba-technical wrote:
>>>> Can you have a go at addressing this by making all of our JSON
>>>> functionality controlled by a --without-json similar to the
>>>> current 
>>>> --without-json-audit?
> 
> for a draft see the attached patch. CI (incomplete as of yet)
> available at https://gitlab.com/samba-team/devel/samba/pipelines/31151475

LGTM.

> Since there now are JSON users in multiple components, I found it
> reasonable to move the switch into the main wscript.
> 
> Any plans to relocate the JSON code out of the audit component
> too?
> 
>>> Is --without-json to supersede --without-json-audit or should
>>> the latter continue to exist so JSON can be disabled locally for
>>> the audit component?
>>
>> It should supersede --without-json-audit.
> 
> The patch drops --without-json-audit entirely, but that switch is
> present in the 4.9 release. Is it alright to break backward
> compatibility of the build like that?

I think so when the builders are asking for it.

People who want JSON for some things and not others can control that via
debug levels.

cheers,
Douglas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 484 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180926/2a5240f2/signature.sig>