[PATCH v8] add JSON output to net ads
Philipp Gesang
philipp.gesang at intra2net.com
Wed Sep 19 08:25:51 UTC 2018
-<| Quoting Andrew Bartlett <abartlet at samba.org>, on Tuesday, 2018-09-18 07:37:27 PM |>-
> On Mon, 2018-09-17 at 17:04 +0200, Philipp Gesang wrote:
> > Hi Gary, others,
> >
> > thanks for the review.
> >
> > >
> > > Looks good, apart from one minor quibble some of the line lengths
> > > are over 80
> > > characters. Once that's fixed I'm happy to give my reviewed by.
> > Done, see v8 attached.
> >
> > CI: https://gitlab.com/samba-team/devel/samba/pipelines/30359226
>
> G'Day Philipp,
>
> I see you have your company copyright on some files. That's fine, but
> you need to send in your DCO to us per the contributing page at the
> wiki.
>
> If you have already done that it's OK, but I can't find the record.
Hi Andrew,
I just emailed the DCO.
Best,
Philipp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180919/c96552f4/signature.sig>
More information about the samba-technical
mailing list