[PATCH] CTDB configuration clean-ups

[Amitay Isaacs]

On Tue, Nov 6, 2018 at 12:00 PM Jeremy Allison <jra at samba.org> wrote:
>
> On Tue, Nov 06, 2018 at 11:50:01AM +1100, Martin Schwenke wrote:
> > On Mon, 5 Nov 2018 15:16:52 -0800, Jeremy Allison <jra at samba.org> wrote:
> >
> > > On Tue, Nov 06, 2018 at 10:05:10AM +1100, Amitay Isaacs via samba-technical wrote:
> > > > On Mon, Nov 5, 2018 at 11:25 AM Martin Schwenke via samba-technical
> > > > <samba-technical at lists.samba.org> wrote:
> > > > >
> > > > > This patch set drops ad hoc usage of CTDB_SOCKET and CTDB_PIDFILE
> > > > > environment variables.  Instead, common path handling is now used
> > > > > throughout the code.  As documented in tests/README, this
> > > > > means that compile-time defaults are used unless CTDB_TEST_MODE and
> > > > > CTDB_BASE are set, in which case locations relative to CTDB_BASE are
> > > > > used.
> > > > >
> > > > > However, note that the first commit adds an exception for CTDB_SOCKET to
> > > > > the common path handling.  This is used when the caller asks for the
> > > > > socket path for "ctdbd" (and when CTDB_SOCKET is set).
> > > > >
> > > > > Please review and maybe push...
> > > >
> > > > In the patch "ctdb-tests: Use path_socket() in dummy client",  there
> > > > is no need to set default options.sockpath using
> > > > talloc_autofree_context().
> > > > Let the default be NULL.  If there is no socket argument, use existing
> > > > mem_ctx to set up the default sockpath.
> > >
> > > Oh yes ! I've managed to remove  all uses of talloc_autofree_context()
> > > from Samba proper (although I have noticed it has crept back into:
> > > lib/ldb/tests/ldb_kv_ops_test.c
> > > I'll have to kill that :-).
> > >
> > > Please do not use this function for *anything* !
> >
> > Can we please mark talloc_autofree_context() as deprecated?
> >
> > I tried doing it but I couldn't figure out how to make the compiler
> > complain...  ;-)
>
> Does this work ? Please review and push if happy :-).

Yup that works.  Pushed along with Martin's patches.

Amitay.