[cifs:for-next 5/8] fs/cifs/cifs_debug.c:87:4: error: too few arguments to function 'cifs_dump_detail'

Steve French smfrench at gmail.com
Sun May 6 21:02:36 UTC 2018


fixed in cifs-2.6.git for-next and repushed

On Sun, May 6, 2018 at 1:49 PM, kbuild test robot <lkp at intel.com> wrote:
> tree:   git://git.samba.org/sfrench/cifs-2.6.git for-next
> head:   bcfd761d3ddda672e8bd541c385426735ea7b847
> commit: 00305145145f62b9eea2508813c9c7a4e078e093 [5/8] cifs: add server argument to the dump_detail method
> config: i386-randconfig-x018-201818 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>         git checkout 00305145145f62b9eea2508813c9c7a4e078e093
>         # save the attached .config to linux build tree
>         make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
>    fs/cifs/cifs_debug.c: In function 'cifs_dump_mids':
>>> fs/cifs/cifs_debug.c:87:4: error: too few arguments to function 'cifs_dump_detail'
>        cifs_dump_detail(mid_entry->resp_buf);
>        ^~~~~~~~~~~~~~~~
>    fs/cifs/cifs_debug.c:45:6: note: declared here
>     void cifs_dump_detail(void *buf, struct TCP_Server_Info *server)
>          ^~~~~~~~~~~~~~~~
> --
>    fs/cifs/connect.c: In function 'cifs_demultiplex_thread':
>>> fs/cifs/connect.c:954:5: error: too few arguments to function 'server->ops->dump_detail'
>         server->ops->dump_detail(buf);
>         ^~~~~~
>
> vim +/cifs_dump_detail +87 fs/cifs/cifs_debug.c
>
> 3979877e5 Steve French    2006-05-31  57
> 3979877e5 Steve French    2006-05-31  58  void cifs_dump_mids(struct TCP_Server_Info *server)
> 3979877e5 Steve French    2006-05-31  59  {
> 8aa26f3ed Pavel Shilovsky 2012-05-17  60  #ifdef CONFIG_CIFS_DEBUG2
> 3979877e5 Steve French    2006-05-31  61        struct list_head *tmp;
> 3979877e5 Steve French    2006-05-31  62        struct mid_q_entry *mid_entry;
> 3979877e5 Steve French    2006-05-31  63
> 3979877e5 Steve French    2006-05-31  64        if (server == NULL)
> 3979877e5 Steve French    2006-05-31  65                return;
> 3979877e5 Steve French    2006-05-31  66
> f96637be0 Joe Perches     2013-05-04  67        cifs_dbg(VFS, "Dump pending requests:\n");
> 3979877e5 Steve French    2006-05-31  68        spin_lock(&GlobalMid_Lock);
> 3979877e5 Steve French    2006-05-31  69        list_for_each(tmp, &server->pending_mid_q) {
> 3979877e5 Steve French    2006-05-31  70                mid_entry = list_entry(tmp, struct mid_q_entry, qhead);
> f96637be0 Joe Perches     2013-05-04  71                cifs_dbg(VFS, "State: %d Cmd: %d Pid: %d Cbdata: %p Mid %llu\n",
> 7c9421e1a Pavel Shilovsky 2012-03-23  72                         mid_entry->mid_state,
> 7c9421e1a Pavel Shilovsky 2012-03-23  73                         le16_to_cpu(mid_entry->command),
> 3979877e5 Steve French    2006-05-31  74                         mid_entry->pid,
> 2b84a36c5 Jeff Layton     2011-01-11  75                         mid_entry->callback_data,
> b6b38f704 Joe Perches     2010-04-21  76                         mid_entry->mid);
> 3979877e5 Steve French    2006-05-31  77  #ifdef CONFIG_CIFS_STATS2
> f96637be0 Joe Perches     2013-05-04  78                cifs_dbg(VFS, "IsLarge: %d buf: %p time rcv: %ld now: %ld\n",
> 7c9421e1a Pavel Shilovsky 2012-03-23  79                         mid_entry->large_buf,
> 3979877e5 Steve French    2006-05-31  80                         mid_entry->resp_buf,
> 3979877e5 Steve French    2006-05-31  81                         mid_entry->when_received,
> b6b38f704 Joe Perches     2010-04-21  82                         jiffies);
> 3979877e5 Steve French    2006-05-31  83  #endif /* STATS2 */
> f96637be0 Joe Perches     2013-05-04  84                cifs_dbg(VFS, "IsMult: %d IsEnd: %d\n",
> f96637be0 Joe Perches     2013-05-04  85                         mid_entry->multiRsp, mid_entry->multiEnd);
> 3979877e5 Steve French    2006-05-31  86                if (mid_entry->resp_buf) {
> 3979877e5 Steve French    2006-05-31 @87                        cifs_dump_detail(mid_entry->resp_buf);
> 3979877e5 Steve French    2006-05-31  88                        cifs_dump_mem("existing buf: ",
> ad7a2926b Steve French    2008-02-07  89                                mid_entry->resp_buf, 62);
> 3979877e5 Steve French    2006-05-31  90                }
> 3979877e5 Steve French    2006-05-31  91        }
> 3979877e5 Steve French    2006-05-31  92        spin_unlock(&GlobalMid_Lock);
> 3979877e5 Steve French    2006-05-31  93  #endif /* CONFIG_CIFS_DEBUG2 */
> 8aa26f3ed Pavel Shilovsky 2012-05-17  94  }
> 3979877e5 Steve French    2006-05-31  95
>
> :::::: The code at line 87 was first introduced by commit
> :::::: 3979877e5606ecc58c5a31bd0078c6d80ba9cbe7 [CIFS] Support for setting up SMB sessions to legacy lanman servers
>
> :::::: TO: Steve French <sfrench at us.ibm.com>
> :::::: CC: Steve French <sfrench at us.ibm.com>
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



-- 
Thanks,

Steve



More information about the samba-technical mailing list