[PATCH] build: add option to choose to build with or without JSON audit support

[Andrew Bartlett]

On Wed, 2018-05-02 at 13:43 +0200, Björn Baumbach wrote:
> 
> Hi Andrew,
> 
> I didn't change the behaviour. The default is still the auto-detection.
> In my opinion this feature is an optional feature and I am fine with the
> current default. 

Sure, but in retrospect I'm not.  This was missed when we first added
the feature.  

> I would not like to set the default to True.

Why is that?  

A while back we realised that folks were getting builds missing
features, so we stopped making krb5 and ldap automatic in this way,
requiring an explicit --without-krb5, --without-ldap et al.  

Now that an explicit option is being added, I'm asking that is match
the behaviour of our other 'optional' libraries.

> In which way would you like to update the man page? The condition "if
> Samba is compiled against the jansson JSON library" is still correct here:
> 
>   Authentication and authorization audit information is logged under
>   the auth_audit, and if Samba is compiled against the jansson JSON
>   library, a JSON representation is logged under auth_json_audit.

How about:

and unless Samba was compiled --without-json-audit, a JSON
representation is logged under auth_json_audit. 

Thanks,

Andrew Bartlett


-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba