[PATCH] Fix strict aliasing warnings in ctdb_client
Martin Schwenke
martin at meltin.net
Tue May 1 06:57:03 UTC 2018
On Tue, 1 May 2018 15:08:12 +1000, Martin Schwenke via samba-technical
<samba-technical at lists.samba.org> wrote:
> On Tue, 1 May 2018 13:01:37 +1000, Amitay Isaacs via samba-technical
> <samba-technical at lists.samba.org> wrote:
>
> > On Mon, Apr 30, 2018 at 7:15 PM, Amitay Isaacs <amitay at gmail.com> wrote:
> > > On Mon, Apr 30, 2018 at 6:49 PM, Stefan Metzmacher <metze at samba.org> wrote:
> [...]
> > [...]
> > [...]
> > [...]
> [...]
> > >
> > > Sure. I still wanted to point out what was wrong with the first patch.
> > >
> > > I am preparing a patch which drops most of the unused functions from
> > > ctdb_client.c.
> > >
> > > Andreas, please file CTDB bugs against CTDB component rather than Clustering.
> > >
> > > Amitay.
> >
> > Here is a patch set that removes all of the unused code from ctdb_client.c.
> > ctdb_client.c is now moved to server/ subdirectory. So all the old
> > style code now lives in server/.
>
> Reviewed-by: Martin Schwenke <martin at meltin.net>
>
> I'll hold off pushing for a little while until the retest of my config
> changes completes. Hopefully we can push both together...
As discussed, only RB+ if you do whitespace fixups. ;-)
peace & happiness,
martin
More information about the samba-technical
mailing list