[PATCH] Improve the wording of wbinfo --online-status

Christof Schmitt cs at samba.org
Fri Mar 16 21:29:12 UTC 2018


On Fri, Mar 16, 2018 at 08:20:10AM +0100, Ralph Böhme via samba-technical wrote:
> On Fri, Mar 16, 2018 at 09:33:03AM +0100, Andreas Schneider via samba-technical wrote:
> > On Thursday, 8 March 2018 15:49:23 CET Andreas Schneider via samba-technical 
> > wrote:
> > > Hi,
> > > 
> > > the problem is that offline means to customers we are not able to talk to
> > > the domain, often trusted domain. I think also it is incorrect as it only
> > > displays if we currently maintain an active connection. Normally we only
> > > maintain an active connection for idmap_ad ...
> > > 
> > > before:
> > > 	wbinfo --online-status
> > > 	DOM1: Online
> > > 	DOM2: Offline
> > > 	DOM3: Offline
> > > 
> > > after:
> > > 	wbinfo --online-status
> > > 	DOM1: active connection
> > > 	DOM2: no active connection
> > > 	DOM3: no active connection
> > > 
> > > 
> > > Review much appreciated.
> > 
> > Ping!
> 
> sorry, forgot to reply. I like it, but I think we need broader consensus
> here. metze, Volker, Christof or others, what do you think?

+1 from me.

As a side note, we have this comment for the online flag:
source3/winbindd/winbindd.h
	bool online;			       /* is this domain available ? */

Should this also be changed to state that the flag indicates whether
winbindd has an open connection to a DC in that domain?

Christof



More information about the samba-technical mailing list