[PATCH] ctdb-server: Introduce mem pool
Martin Schwenke
martin at meltin.net
Fri Mar 16 07:54:38 UTC 2018
On Fri, 16 Mar 2018 08:27:14 +0100, Swen Schillig <swen at vnet.ibm.com>
wrote:
> On Fri, 2018-03-16 at 16:35 +1100, Martin Schwenke via samba-technical
> wrote:
> > On Fri, 09 Mar 2018 09:09:23 +0100, Swen Schillig via samba-technical
> > <samba-technical at lists.samba.org> wrote:
> >
> > > Please review and push if OK.
> >
> > - if ((rev_hdl = talloc_zero(ctdb_db, struct
> > revokechild_handle)) == NULL) {
> > + rev_hdl = talloc_pooled_object(ctdb_db, struct
> > revokechild_handle, 2,
> > + data.dsize + key.dsize);
> >
> > I don't see where this function does an allocation of size
> > data.dsize. :-(
> >
> > peace & happiness,
> > martin
> >
> you're right, I guess this got "fixed" in the last run.
>
> But now, really fixed.
EWRONGPATCH? Or does this previous patch need fixing to get the
"Introduce mem pool" one to work properly?
peace & happiness,
martin
More information about the samba-technical
mailing list