[PATCHES] Fix build with system provided Heimdal library

[Andrew Bartlett]

On Tue, 2018-06-26 at 15:07 -0700, Christof Schmitt via samba-technical 
wrote:
> This was triggered by the fact that Ubuntu 18.04 provides libldap that
> depends on the Heimdal kerberos library. Building a simple Samba file
> server with the requirement that only one Kerberos is used, then
> requires building against the system provided Heimdal library (as
> libldap already has the dependency).
> 
> The configure command which allowed this to work was:
> 
> ./configure \
>  --bundled-libraries='!heimdal,!asn1,!com_err,!roken,!hx509,!wind,!gssapi,!hcrypto,!krb5,!heimbase,!asn1_compile,!compile_et,!kdc,!hdb,!heimntlm'
>  --without-ad-dc --disable-cups
> 
> Note that on this system --disable-cups was required as well, as libcups
> in Ubuntu 18.04 depends on MIT kerberos.
> 
> The two attached patches are required for this build to succeed.

G'Day Christof,

I'm surprised this hasn't come up before.  Is it your additional
requirement that you only have one krb5 lib, or has something changed
on the Ubuntu side?  It just feels very strange at this point. 

If we are to allow that we need to bundle it up into a sensible option
like the --with-system-mitkrb5, and force it to fail unless --without-
ad-dc is set.

We would also need an autobuild target and to update the docker
container and sn-devel to match. 

In the meantime can you push a branch to gitlab so we can see what this
change does to the rest of the build?

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba